From eca0cb57f949e3c66b6aa74fca6acf01b2e5f927 Mon Sep 17 00:00:00 2001
From: Michel Roegl-Brunner <michel.roegl-brunner@htl-braunau.at>
Date: Fri, 24 Oct 2025 22:30:15 +0200
Subject: [PATCH] Fix TypeScript linting errors in autoSyncService

- Add JSDoc type definitions for settings object
- Fix appriseUrls undefined checks
- Fix null assignment for lastAutoSyncError
- Add proper type annotations for error fields

All TypeScript linting errors are now resolved.
---
 src/server/services/autoSyncService.js | 23 +++++++++++++++++++----
 1 file changed, 19 insertions(+), 4 deletions(-)

diff --git a/src/server/services/autoSyncService.js b/src/server/services/autoSyncService.js
index 6616d80..6fc5bc9 100644
--- a/src/server/services/autoSyncService.js
+++ b/src/server/services/autoSyncService.js
@@ -42,6 +42,19 @@ export class AutoSyncService {
       const envPath = join(process.cwd(), '.env');
       const envContent = readFileSync(envPath, 'utf8');
       
+      /** @type {{
+       *   autoSyncEnabled: boolean;
+       *   syncIntervalType: string;
+       *   syncIntervalPredefined?: string;
+       *   syncIntervalCron?: string;
+       *   autoDownloadNew: boolean;
+       *   autoUpdateExisting: boolean;
+       *   notificationEnabled: boolean;
+       *   appriseUrls?: string[];
+       *   lastAutoSync?: string;
+       *   lastAutoSyncError?: string;
+       *   lastAutoSyncErrorTime?: string;
+       * }} */
       const settings = {
         autoSyncEnabled: false,
         syncIntervalType: 'predefined',
@@ -139,6 +152,8 @@ export class AutoSyncService {
    * @param {boolean} settings.notificationEnabled
    * @param {Array<string>} [settings.appriseUrls]
    * @param {string} [settings.lastAutoSync]
+   * @param {string} [settings.lastAutoSyncError]
+   * @param {string} [settings.lastAutoSyncErrorTime]
    */
   saveSettings(settings) {
     try {
@@ -470,7 +485,7 @@ export class AutoSyncService {
       }
       
       // Step 3: Send notifications if enabled
-      if (settings.notificationEnabled && settings.appriseUrls?.length > 0) {
+      if (settings.notificationEnabled && settings.appriseUrls && settings.appriseUrls.length > 0) {
         console.log('Sending success notifications...');
         await this.sendSyncNotification(results);
         console.log('Success notifications sent');
@@ -481,7 +496,7 @@ export class AutoSyncService {
       const updatedSettings = { 
         ...settings, 
         lastAutoSync: lastSyncTime,
-        lastAutoSyncError: null // Clear any previous errors on successful sync
+        lastAutoSyncError: '' // Clear any previous errors on successful sync
       };
       this.saveSettings(updatedSettings);
       
@@ -504,7 +519,7 @@ export class AutoSyncService {
       
       // Send error notification if enabled
       const settings = this.loadSettings();
-      if (settings.notificationEnabled && settings.appriseUrls?.length > 0) {
+      if (settings.notificationEnabled && settings.appriseUrls && settings.appriseUrls.length > 0) {
         try {
           const notificationTitle = isRateLimitError ? 'Auto-Sync Rate Limited' : 'Auto-Sync Failed';
           const notificationMessage = isRateLimitError 
@@ -514,7 +529,7 @@ export class AutoSyncService {
           await appriseService.sendNotification(
             notificationTitle,
             notificationMessage,
-            settings.appriseUrls
+            settings.appriseUrls || []
           );
         } catch (notifError) {
           console.error('Failed to send error notification:', notifError);